Mutation effects that apply to plant should apply when planted #32258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Status: Needs Review
|
How does it work at the moment? Is it waiting a few seconds for the plantholder to update? |
|
The plant holder does not check the seed's mutation list for visual updates. This is different from the other values. This PR is a quick fix to get behavior closer to the original. The current behavior puts the mutation on the seed but doesn't apply them when planting, so produce will glow when harvested, but the plant(holder) itself doesn't change if you use a clipping that has a mutation on it. |
|
Closing, since this will also be resolved with #31941 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Effect mutations that apply to a plant (glow, etc) are now applied when planted.
Why / Balance
When you make a clipping from a plant with an effect, you expect that effect to be immediately visible.
Technical details
Checks for and apply any relevant effects when the seed is planted.
Media
fix, no image
Requirements
Breaking changes
Changelog
🆑